[tor-dev] ENGINE_get_default_ECDx missing?

[rl1987]

Thanks, registered this patch in #17984.

2016-01-18 19:43, Gisle Vanem wrote:
> Seems these two OpenSSL functions:
>   ENGINE_get_default_ECDSA()
>   ENGINE_get_default_ECDH()
> 
> have been dropped; in util/libeay32.num:
>   ...
>   ENGINE_get_default_ECDH         3387    1_1_0   NOEXIST::FUNCTION:
>   ENGINE_get_default_ECDSA        3662    1_1_0   NOEXIST::FUNCTION:
>   ...
> 
> https://raw.githubusercontent.com/openssl/openssl/master/util/libeay.num
> 
> (not sure exactly what 'NOEXIST' does). So shouldn't common/crypto.c
> be patched into something like:
> 
> --- a/src/common/crypto.c 2016-01-14 22:29:59
> +++ b/src/common/crypto.c 2016-01-18 17:55:53
> @@ -373,8 +373,10 @@
>           used by Tor and the set of algorithms available in the engine 
> */
>        log_engine("RSA", ENGINE_get_default_RSA());
>        log_engine("DH", ENGINE_get_default_DH());
> +#if OPENSSL_VERSION_NUMBER < OPENSSL_V_SERIES(1,1,0)
>        log_engine("ECDH", ENGINE_get_default_ECDH());
>        log_engine("ECDSA", ENGINE_get_default_ECDSA());
> +#endif
>        log_engine("RAND", ENGINE_get_default_RAND());
>        log_engine("RAND (which we will not use)", 
> ENGINE_get_default_RAND());
>        log_engine("SHA1", ENGINE_get_digest_engine(NID_sha1));
> 
> Isn't OpenSSL 1.1.0 supported yet? Scratching head...
> 
> BTW, I'm using TDM-gcc 5.1 (http://tdm-gcc.tdragon.net/)
>  on Win-10.