[tor-bugs] #31652 [Core Tor/Tor]: hs-v3: Service circuit retry limit should not close a valid circuit

[Tor Bug Tracker & Wiki]

#31652: hs-v3: Service circuit retry limit should not close a valid circuit
---------------------------------------------+-----------------------------
 Reporter:  dgoulet                          |          Owner:  neel
     Type:  defect                           |         Status:
                                             |  needs_revision
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.4.2.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  tor-hs, tor-circuit, 042-should  |  Actual Points:
Parent ID:  #30200                           |         Points:  0.1
 Reviewer:  asn                              |        Sponsor:
                                             |  Sponsor27-must
---------------------------------------------+-----------------------------
Changes (by asn):

 * status:  needs_review => needs_revision


Comment:

 OK this is much better. I really understand the logic now. Thanks!

 That said, you changed the behavior of the code in the latest iteration
 which I was not expecting (I was just expecting documentation). In
 particular, the code now avoids removing the intro circ if
 `hs_circ_service_get_intro_circ()` is true (which makes sense!) whereas
 before it was doing the exact opposite.

 How could you fix that bug without the unittest noticing at all? Can you
 please enrich the unittest so that it catches such bugs in the future?

 We are almost there!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31652#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online