[tor-bugs] #31652 [Core Tor/Tor]: hs-v3: Service circuit retry limit should not close a valid circuit

[Tor Bug Tracker & Wiki]

#31652: hs-v3: Service circuit retry limit should not close a valid circuit
---------------------------------------------+-----------------------------
 Reporter:  dgoulet                          |          Owner:  neel
     Type:  defect                           |         Status:
                                             |  needs_review
 Priority:  Medium                           |      Milestone:  Tor:
                                             |  0.4.2.x-final
Component:  Core Tor/Tor                     |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  tor-hs, tor-circuit, 042-should  |  Actual Points:
Parent ID:  #30200                           |         Points:  0.1
 Reviewer:  asn                              |        Sponsor:
                                             |  Sponsor27-must
---------------------------------------------+-----------------------------
Changes (by neel):

 * status:  needs_revision => needs_review


Comment:

 I have clarified the code, calling the new function
 `should_remove_intro_point()` and simplified the logic.

 The code works this way:

 If this statement is true:

 {{{
     if (ip->circuit_established || hs_circ_service_get_intro_circ(ip))
 }}}

 We return `false` to not destroy the circuit. Otherwise, we return this
 test case:

 {{{
   return (ip->circuit_retries > MAX_INTRO_POINT_CIRCUIT_RETRIES);
 }}}

 Setting as needs review.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31652#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online