[tor-bugs] #31736 [Core Tor/Tor]: Stop using mutex_destroy(), when multiple threads can still access the mutex

[Tor Bug Tracker & Wiki]

#31736: Stop using mutex_destroy(), when multiple threads can still access the
mutex
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.2.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.5.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  consider-backport-after-042-stable,  |  Actual Points:
  consider-backport-if-needed, diagnostics,      |
  042-should, 035-backport-maybe, 040-backport-  |
  maybe, 041-backport-maybe, regression,         |
  BugSmashFund                                   |
Parent ID:  #31614                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 I spoke with nickm on IRC, and he agreed:
 * we will stop calling mutex destroy on static pthread mutexes
   * need to check the windows rules
 * we'll have to make sure asan and valgrind don't think it's a leak
 * we should leave a comment on the functions that still need to call mutex
 destroy, and the places where we remove the mutex destroys

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31736#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online