[tor-bugs] #31736 [Core Tor/Tor]: Stop using mutex_destroy(), when multiple threads can still access the mutex

[Tor Bug Tracker & Wiki]

#31736: Stop using mutex_destroy(), when multiple threads can still access the
mutex
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.4.2.x-final
    Component:  Core     |    Version:  Tor: 0.3.5.1-alpha
  Tor/Tor                |   Keywords:  consider-backport-after-042-stable,
     Severity:  Normal   |  consider-backport-if-needed, diagnostics,
                         |  042-should, 035-backport-maybe, 040-backport-
                         |  maybe, 041-backport-maybe, regression,
                         |  BugSmashFund
Actual Points:           |  Parent ID:  #31614
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 Part of #31614, alternative to #31735.

 If we can't join all the threads before destroying a mutex (#31735), and
 we can't otherwise prevent multiple thread access, we should stop
 destroying that mutex. (Because destroying a locked thread invokes
 undefined behaviour.)

 There may be some other pattern that helps us destroy all but one mutex.
 But that involves a "mutex-destruction" mutex. Which is terribly complex.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/31736>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online