[tor-bugs] #32194 [Metrics/Library]: NetworkStatusEntryImpl#parseSLine (and probably other methods) is not thread-safe

[Tor Bug Tracker & Wiki]

#32194: NetworkStatusEntryImpl#parseSLine (and probably other methods) is not
thread-safe
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  defect           |         Status:  merge_ready
 Priority:  High             |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  irl              |        Sponsor:
-----------------------------+------------------------------
Changes (by irl):

 * status:  needs_review => merge_ready


Comment:

 LGTM.

 I have noticed that the Onionoo updater is finishing very close to the
 next start time. We're seeing that sometimes it is taking too long (hence
 we get a pile of alerts from Nagios that the time is older than 2 hours,
 which get resolved quite quickly). We should be thinking about thread-
 safety in any new code to avoid this being a problem later.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32194#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online