[tor-bugs] #32194 [Metrics/Library]: NetworkStatusEntryImpl#parseSLine (and probably other methods) is not thread-safe

[Tor Bug Tracker & Wiki]

#32194: NetworkStatusEntryImpl#parseSLine (and probably other methods) is not
thread-safe
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  defect           |         Status:  needs_review
 Priority:  High             |      Milestone:
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:  irl              |        Sponsor:
-----------------------------+------------------------------
Changes (by karsten):

 * status:  new => needs_review
 * reviewer:   => irl


Comment:

 While writing a fix for this particular issue with parsing `"s"` lines I
 didn't find any similar issues. We do have similar code in Onionoo, which
 is not thread-safe either. But we're also not using multiple threads in
 the Onionoo updater, so that's not an issue.

 I'm going to do some more testing with multi-threaded parsing in metrics-
 lib in the near future. Just in case there are more issues, I might spot
 them. For now, I'll assume this was the only such case.

 Please review [https://gitweb.torproject.org/user/karsten/metrics-
 lib.git/commit/?h=task-32194&id=a99e20bba2b0df434fa03cd4f41d0655ec6b63cc
 commit a99e20b in my task-32194 branch].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32194#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online