[tor-bugs] #29754 [Core Tor/Tor]: Include new monitoring KeyValues in the bandwidth-file-spec

[Tor Bug Tracker & Wiki]

#29754: Include new monitoring KeyValues in the bandwidth-file-spec
-------------------------------------------------+-------------------------
 Reporter:  juga                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-spec, bandwidth-file-spec, tor-  |  Actual Points:
  bwauth                                         |
Parent ID:  #28547                               |         Points:  1
 Reviewer:  teor, juga                           |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by juga):

 Replying to [comment:16 teor]:
 > Replying to [comment:10 juga]:
 > > I created https://github.com/teor2345/torspec/pull/1 against your PR
 68, fixing some of the things i commented in the review, but not all.
 >
 > I reviewed your pull request.
 > Most of the commits are good, but we can't wrap example bandwidth file
 lines.

 ok, i did it cause i was getting lost myself in such long lines, but i've
 removed the new lines now.
 If a parser uses the Values exactly as they're in the examples, the
 headers don't match with the lines. Maybe i could just put them in
 different subsections so that it is a bit more clear that they don't
 match?.
 If i change the number in the header to match the lines, then it would not
 be that realistic.

 > > Not closing https://github.com/torproject/torspec/pull/68 because i'm
 not sure what you think about the other comments i made.
 >
 > I responded to your comments. I can fix the remaining issues.

 ack

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29754#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online