[tor-bugs] #25837 [Applications/Tor Browser]: Integrate fxc2 into our build setup for Windows Tor Browser builds

[Tor Bug Tracker & Wiki]

#25837: Integrate fxc2 into our build setup for Windows Tor Browser builds
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, ff60-esr,                   |  Actual Points:
  TorBrowserTeam201806                           |
Parent ID:  #26203                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by boklm):

 I am now testing a build with the following changes compared to the patch
 from branch `azadi/bug-26203`:
 * remove the line `pre_pkginst: dpkg --add-architecture i386` as it builds
 fine without it. https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26203&id=e172a942f2abf3553f14f2de7be20840f5f77334
 * don't use xvfb as it seems it is not really needed.
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26203&id=ecea9b7944aa0ea22faf72776e0050c6d9ca1bad
 * copy d3dcompiler_47.dll (this change was part of commit `Bug 26206: Ship
 pthread related dll (libwinpthread-1.dll) where needed` before)
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_26203&id=74da109534fe4c5470a7653ddcba83398c1ac7f4
 * Simplify a little the copy of the libwinpthread-1.dll file.
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837&id=b0f30a7078c145916e0e89b255dd2262fc757730
 * Remove the `&` after `wine wineboot -i` as I am not sure it is needed.
 https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_25837&id=9d4ab9c0a171be5c38d9f440bb855d92c9b0faa2

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25837#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online