[tor-bugs] #24898 [Core Tor/Tor]: We have two conflicting notions of channel_is_client()

Mon Jan 15 08:26:34 UTC 2018

#24898: We have two conflicting notions of channel_is_client()
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 Right now, in channel_tls_process_netinfo_cell(), for the
 OR_CONN_STATE_OR_HANDSHAKING_V3 case, we call channel_mark_client()
 properly.

 I propose that we call everything a client that handshakes with
 OR_CONN_STATE_OR_HANDSHAKING_V1 or OR_CONN_STATE_OR_HANDSHAKING_V2, since
 relays should never use those legacy handshakes with other relays at this
 point.

 And then we can happily remove the dangerous clause from command.c.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24898#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online