[tor-bugs] #24898 [Core Tor/Tor]: We have two conflicting notions of channel_is_client()

Mon Jan 15 08:23:42 UTC 2018

#24898: We have two conflicting notions of channel_is_client()
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by arma):

 Replying to [ticket:24898 arma]:
 > full of false positives

 I discovered this bug while working on the current circuit / conn overload
 patches, considering blacklisting client IP addresses that misbehave in
 certain ways. I found that my fast relay has a *lot* of conns that are
 marked as channel_is_client() that are very clearly connections to/from
 relays.

 I assume the conns started off not marked as clients, and then the clause
 in command.c declared them as clients.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24898#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online