[tor-bugs] #17945 [Core Tor/Tor]: Stop Tor2Web connecting to (Rendezvous) Single Onion Services

[Tor Bug Tracker & Wiki]

#17945: Stop Tor2Web connecting to (Rendezvous) Single Onion Services
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor2web, tor-hs, 029-proposed, 029   |  Actual Points:
  -teor-no, needs-design, needs-proposal-maybe,  |
  single-onion, review-group-33                  |
Parent ID:  #24962                               |         Points:  5
 Reviewer:  asn, teor                            |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 Replying to [comment:41 dgoulet]:
 > I think the patch would simply looks like this. Nothing final, I just
 want feedback.
 >
 > Branch: `ticket17945_033_01`

 I guess that looks simple and decent enough. Is it guaranteed that
 `p_chan` will exist for those circuits? Should we check the existence of
 those `p_chan`s before we call `channel_is_client()` on them? Other than
 that, LGTM.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/17945#comment:46>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online