[tor-bugs] #24384 [Metrics/Onionoo]: Decode percent-encoded characters in qualified search terms

[Tor Bug Tracker & Wiki]

#24384: Decode percent-encoded characters in qualified search terms
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  defect           |         Status:  new
 Priority:  High             |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by karsten):

 Fine question. The main reason I put it in was for the unit tests to still
 succeed. In particular, the following two tests stop working without that
 replacement:

  - `/summary?search=ACXBNsHzqe7+KuP5GPA7+iG1Bws`
  - `/summary?search=contact:<tor+steven.murdoch at cl.cam.ac.uk>`.

 I didn't check how Relay Search would encode these searches on the wire.
 Do you have an easy way to say that?

 It seems that we'd still need it for PHP variants of Relay Search to work.
 Unless PHP is doing it "wrong". If we can reasonably expect `+` to be
 encoded as `%20` I could imagine taking out that `replaceAll()` and
 changing unit tests accordingly. That would probably require a major
 protocol version bump.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24384#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online