[tor-bugs] #24384 [Metrics/Onionoo]: Decode percent-encoded characters in qualified search terms

Wed Nov 22 11:43:04 UTC 2017

#24384: Decode percent-encoded characters in qualified search terms
-----------------------------+------------------------------
 Reporter:  karsten          |          Owner:  metrics-team
     Type:  defect           |         Status:  new
 Priority:  High             |      Milestone:
Component:  Metrics/Onionoo  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:                   |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:
-----------------------------+------------------------------

Comment (by irl):

 This looks good to me.

 The `+` issue is interesting. Were you getting `+` from Relay Search or
 are you just adding this pre-emptively?

 PHP seems to encode spaces to `+` in `urlencode()` but JavaScript's
 `encodeURIComponent()` makes them into `%20`. Behaviour seems to
 annoyingly vary depending on what you're encoding with.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24384#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online