[tor-bugs] #23304 [Core Tor/Tor]: prop224: Dump a malformed descriptor in a file and log_warn about it

[Tor Bug Tracker & Wiki]

#23304: prop224: Dump a malformed descriptor in a file and log_warn about it
-----------------------------+------------------------------------
 Reporter:  dgoulet          |          Owner:  (none)
     Type:  defect           |         Status:  new
 Priority:  Medium           |      Milestone:  Tor: 0.3.2.x-final
Component:  Core Tor/Tor     |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  tor-hs, prop224  |  Actual Points:
Parent ID:  #23300           |         Points:
 Reviewer:                   |        Sponsor:  SponsorR-can
-----------------------------+------------------------------------

Comment (by arma):

 Replying to [ticket:23304 dgoulet]:
 > Worth thinking if we might want that only with `SafeLogging 0` since
 leaving HS descriptors on disk client side might not be ideal?
 >
 > As for v2 subsystem, the onion address is in the descriptor so I would
 be very careful to put that on disk.

 These are two sides of the same argument: a v3 descriptor is still
 recognizable as corresponding to a given onion address if you know the
 onion key that generated it. Though heck, an intentionally malformed
 descriptor is recognizable no matter what our protocol specifications say.
 ("You tried to fetch the descriptor for this onion service that I hate?
 Here, let me give you a unique cookie that you'll write to disk.")

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23304#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online