[tor-bugs] #23304 [Core Tor/Tor]: prop224: Dump a malformed descriptor in a file and log_warn about it

[Tor Bug Tracker & Wiki]

#23304: prop224: Dump a malformed descriptor in a file and log_warn about it
------------------------------+--------------------------------
     Reporter:  dgoulet       |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.2.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-hs, prop224
Actual Points:                |  Parent ID:  #23300
       Points:                |   Reviewer:
      Sponsor:  SponsorR-can  |
------------------------------+--------------------------------
 Once a client fetches a descriptor, it could be unparseable thus
 malformed. Dump it in a file and warn about it so the user can report it
 properly to us and we also don't have a 50kb blob of text in the logs.

 Worth thinking if we might want that only with `SafeLogging 0` since
 leaving HS descriptors on disk client side might not be ideal?

 As for v2 subsystem, the onion address is in the descriptor so I would be
 very careful to put that on disk.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23304>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online