[tor-bugs] #19195 [Core Tor/Tor]: [prop250] Remove unnecessary assertion in sr_compute_srv

Tor Bug Tracker & Wiki blackhole at torproject.org
Sat May 28 13:55:48 UTC 2016


#19195: [prop250] Remove unnecessary assertion in sr_compute_srv
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  closed
 Priority:  Medium        |      Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:  fixed
 Keywords:  tor-hs        |  Actual Points:
Parent ID:  #16943        |         Points:  0.1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Indeed, that's useless. It's a artifact of the past when reveal_num was a
 `size_t` but we expected a `INT_1` so that assert was added but now it's
 useless.

 Fixed and pushed in the main prop250 branch in #16943.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19195#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list