[tor-bugs] #19195 [Core Tor/Tor]: [prop250] Remove unnecessary assertion in sr_compute_srv

[Tor Bug Tracker & Wiki]

#19195: [prop250] Remove unnecessary assertion in sr_compute_srv
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.2.9.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  tor-hs
Actual Points:                |  Parent ID:  #16943
       Points:  0.1           |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 In dgoulet's srv-testing-2, git 0234595:

 In sr_compute_srv, this doesn't make much sense:
 {{{
 uint64_t reveal_num;
 ...
 tor_assert(reveal_num < UINT64_MAX);
 }}}

 Why stop reveal_num being equal to UINT64_MAX?
 There's absolutely no harm in it being equal.

 Let's just delete the condition.
 (Or provide a comment saying why we're checking.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19195>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online