[tor-bugs] #18106 [Tor]: Rename fascist_firewall_* functions to reachable_address_*

[Tor Bug Tracker & Wiki]

#18106: Rename fascist_firewall_* functions to reachable_address_*
-----------------------------+--------------------------------
     Reporter:  teor         |      Owner:
         Type:  enhancement  |     Status:  new
     Priority:  Medium       |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor          |    Version:
     Severity:  Normal       |   Keywords:  easy
Actual Points:               |  Parent ID:
       Points:               |    Sponsor:
-----------------------------+--------------------------------
 In #17840 and #9067 / #9068, we unified ReachableAddresses and
 ClientUseIPv4/ClientUseIPv6/UseBridges. We'd previously unified
 FascistFirewall, FirewallPorts and ReachableAddresses.

 This means that the functions called fascist_firewall_* should probably be
 renamed to be more descriptive.

 I think reachable_address_* is one option, but let's follow typical naming
 standards and not repeat words in names:
 * fascist_firewall_choose_address_dir_server ->
 * reachable_address_choose_address_dir_server ->
 * reachable_address_choose_dir_server

 Let's also use this as an opportunity to disambiguate
 fascist_firewall_choose_address_impl &
 fascist_firewall_choose_address_base.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18106>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online