[tor-bugs] #18105 [Tor]: Replace getsockname with tor_getsockname

[Tor Bug Tracker & Wiki]

#18105: Replace getsockname with tor_getsockname
-----------------------------+--------------------------------
     Reporter:  teor         |      Owner:
         Type:  enhancement  |     Status:  new
     Priority:  Medium       |  Milestone:  Tor: 0.2.8.x-final
    Component:  Tor          |    Version:
     Severity:  Normal       |   Keywords:  easy
Actual Points:               |  Parent ID:
       Points:               |    Sponsor:
-----------------------------+--------------------------------
 There's a lot of duplicate code in Tor that calls getsockname, then stuffs
 the address in a tor_addr_t.

 Let's cleanup that code by replacing it with tor_getsockname where that
 makes sense.

 For example, in #18100, we left behind duplicate code in
 destination_from_socket, because it was a backport, and the changes
 required to deduplicate it were complex.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/18105>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online