[tor-bugs] #20458 [Core Tor/Tor]: Integration tests should be run locally before committing code changes

[Tor Bug Tracker & Wiki]

#20458: Integration tests should be run locally before committing code changes
----------------------------------------------+----------------------------
 Reporter:  chelseakomlo                      |          Owner:
                                              |  chelseakomlo
     Type:  enhancement                       |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.1.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  test, doc, triage-out-030-201612  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:  teor                              |        Sponsor:
----------------------------------------------+----------------------------

Comment (by chelseakomlo):

 Thanks for the feedback- see
 `git at github.com:chelseakomlo/tor_patches.git`, branch
 `documentation_integ_tests` with these changes.

 Replying to [comment:21 cypherpunks]:
 > With #5500 being implemented, `make check` now runs the `check-spaces`
 target. Because `make distcheck` also runs `make check` when it tests the
 distribution, asking developers to call `make check-spaces` separately is
 redundant. Maybe you can remove the lines mentioning `make check-spaces`?

 Sure, good point. See `dfde58db6b4ca0b406b872d7b049efbe07d7a0fe`

 > Also IMHO the commit message of
 `ff085157a5b8ecff00604e3a78295d271cda0c51` is too long.

 Fair. See `d95678ca8f97ac6e648598af01b4394840999e72`

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20458#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online