[tor-bugs] #20458 [Core Tor/Tor]: Integration tests should be run locally before committing code changes
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Dec 21 21:20:20 UTC 2016
#20458: Integration tests should be run locally before committing code changes
----------------------------------------------+----------------------------
Reporter: chelseakomlo | Owner:
| chelseakomlo
Type: enhancement | Status:
| needs_review
Priority: Medium | Milestone: Tor:
| 0.3.1.x-final
Component: Core Tor/Tor | Version:
Severity: Normal | Resolution:
Keywords: test, doc, triage-out-030-201612 | Actual Points:
Parent ID: | Points:
Reviewer: teor | Sponsor:
----------------------------------------------+----------------------------
Comment (by cypherpunks):
With #5500 being implemented, `make check` now runs the `check-spaces`
target. Because `make distcheck` also runs `make check` when it tests the
distribution, asking developers to call `make check-spaces` separately is
redundant. Maybe you can remove the lines mentioning `make check-spaces`?
Also IMHO the commit message of `ff085157a5b8ecff00604e3a78295d271cda0c51`
is too long.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20458#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list