[tor-bugs] #4771 [BridgeDB]: bridgedb should make clearer in its logs which addresses it knows are from bulk-exitlist

[Tor Bug Tracker & Wiki]

#4771: bridgedb should make clearer in its logs which addresses it knows are from
bulk-exitlist
--------------------------+--------------------------------------------
     Reporter:  arma      |      Owner:  isis
         Type:  defect    |     Status:  needs_information
     Priority:  minor     |  Milestone:
    Component:  BridgeDB  |    Version:
   Resolution:            |   Keywords:  isis2015Q1Q2, isisExB, isisExC
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+--------------------------------------------

Comment (by isis):

 For now, I propose the following changes:

 {{{
 diff --git i/lib/bridgedb/Dist.py w/lib/bridgedb/Dist.py
 index c2a8620..65a2f75 100644
 --- i/lib/bridgedb/Dist.py
 +++ w/lib/bridgedb/Dist.py
 @@ -284,16 +283,21 @@ class IPBasedDistributor(Distributor):
          # try to match the request to an ip category
          for category in self.categories:
              # IP Categories
 -            if category.contains(ip):
 +            if ip in category:
 +                # The tag is a tag applied to a proxy IP address when it
 is
 +                # added to the bridgedb.proxy.ProxySet. For Tor Exit
 relays,
 +                # the default is 'exit_relay'. For other proxies loaded
 from
 +                # the PROXY_LIST_FILES config option, the default tag is
 the
 +                # full filename that the IP address originally came from.
 +                tag = category.getTag(ip)
 +                logging.info("Client was from known proxy (tag: %s): %s"
 +                             % (tag, ip))
                  g = filterAssignBridgesToRing(self.splitter.hmac,
                                                self.nClusters +
                                                len(self.categories),
                                                n)
                  bridgeFilterRules.append(g)
 -                logging.info("category<%s>%s", epoch, logSafely(area))
 -                pos = self.areaOrderHmac("category<%s>%s" % (epoch,
 area))
 +                pos = self.areaOrderHmac("<%s>known-proxy" % epoch)
                  break
              n += 1
 }}}

 This fixes the issue with confusing logging, and also fixes the issue that
 changing your Tor exit gets you different bridges.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4771#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online