[tor-bugs] #14429 [Tor Browser]: Automated rounding of content window dimensions

[Tor Bug Tracker & Wiki]

#14429: Automated rounding of content window dimensions
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  arthuredelstein        |     Status:  needs_revision
         Type:  defect   |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-fingerprinting-resolution, tbb-
  Browser                |  torbutton, TorBrowserTeam201502
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by gk):

 * cc: gacar (added)


Comment:

 Replying to [comment:6 arthuredelstein]:
 > Here's a new version of the patch that auto-trims the window after the
 user resizes it. That way we don't have ugly gray bars taking up a lot of
 screen space.
 >
 >
 https://github.com/arthuredelstein/torbutton/commit/e05b071304c42d0f55770ef3fddd38953a53d4ee

 Looks much better, thanks! Two comments:

 1) I think we should keep the 200x100 rounding as we already do on start-
 up for now. Vertical space is precious (assuming we have a user with a
 horizontal display as we are currently doing). However, having some more
 data driven clues would be really nice. See:
 https://trac.torproject.org/13025#comment:17 for a beginning. As a side
 note: there has already been a wrestling in the past with rounding windows
 to 50px x 50 px: https://www.torproject.org/docs/torbutton/en/design/
 (section Resize windows to multiples of 50px during Tor usage
 (recommended)) + see #3506...

 2) Your patch re-rounded the already rounded window on start-up which is
 quite confusing: the properly rounded window shows up and then your logic
 kicks in making the window smaller. I think the resizing logic works on
 start-up in the most cases. Thus, what about only resizing again with your
 logic if there is no multiple of 200x100 after start-up? This should be
 easily doable and does not scare the user so much ("What the heck is going
 on with my browser windows here???") provided she already has rounded
 dimensions.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14429#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online