[tor-bugs] #15493 [Tor Browser]: Redirects sometimes seem to break circuit status UI
Tor Bug Tracker & Wiki
blackhole at torproject.org
Tue Aug 25 17:48:09 UTC 2015
#15493: Redirects sometimes seem to break circuit status UI
-------------------------+-------------------------------------------------
Reporter: | Owner: gk
mikeperry | Status: needs_review
Type: defect | Milestone:
Priority: normal | Version:
Component: Tor | Keywords: tbb-circuit-display, tbb-5.0,
Browser | TorBrowserTeam201508R
Resolution: | Parent ID:
Actual Points: |
Points: |
-------------------------+-------------------------------------------------
Comment (by arthuredelstein):
Replying to [comment:15 gk]:
> This looks good. I only found some nits:
> {{{
> // __collectIsolationData(aController)__.
> }}}
> This one has now a second argument. Could you add as well a comment why
it was necessary maybe pointing to this ticket?
>
> s/Whenever user starts/Whenever a user starts/ (or "Whenever the user
starts")
>
> s/while popup menu is open/while the popup menu is open/
>
> s/before popup menu is shown/before the popup menu is shown/
Hm, I seem to have been in the mood to drop definite articles.
Thanks for the review. Here's the new version with fixes as suggested:
https://github.com/arthuredelstein/torbutton/commit/15493+2
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15493#comment:16>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tor-bugs
mailing list