[tor-bugs] #7112 [Tor]: tor_addr_is_internal_() - non-IP address of type 0

[Tor Bug Tracker & Wiki]

#7112: tor_addr_is_internal_() - non-IP address of type 0
-----------------------------------+----------------------------------------
    Reporter:  mazda               |        Type:  defect              
      Status:  needs_revision      |    Priority:  major               
   Milestone:  Tor: 0.2.4.x-final  |   Component:  Tor                 
     Version:                      |    Keywords:  tor_addr_is_internal
      Parent:                      |      Points:                      
Actualpoints:                      |  
-----------------------------------+----------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 Replying to [comment:10 nickm]:
 > One remaining mystery is why this warning appeared about when we merged
 the channel code; I don't see any change that would make it start
 happening.

 Oh hey.  Instead of copying the circuit's or_connection's address into the
 edge_connection's address in connection_exit_begin_conn, we instead assign
 the output of channel_get_actual_remote_descr().  But that includes a
 port.  I wonder if something else was parsing that...

 And hey, check out this part of 4768c0efe3e9471cc367c3740d1a4ba0ab79626c:
 {{{
    if (rh.command == RELAY_COMMAND_BEGIN_DIR) {
      tor_assert(or_circ);
 -    if (or_circ->p_conn &&
 !tor_addr_is_null(&or_circ->p_conn->real_addr))
 -      tor_addr_copy(&n_stream->_base.addr, &or_circ->p_conn->real_addr);
      return connection_exit_connect_dir(n_stream);
    }
 }}}

 There's the bug!

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/7112#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online