[tor-bugs] #6475 [Tor Client]: circuit_send_next_onion_skin(): Bug: Unexpectedly high circuit_successes

[Tor Bug Tracker & Wiki]

#6475: circuit_send_next_onion_skin(): Bug: Unexpectedly high circuit_successes
-----------------------------+----------------------------------------------
 Reporter:  grarpamp         |          Owner:  mikeperry         
     Type:  defect           |         Status:  assigned          
 Priority:  major            |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client       |        Version:  Tor: 0.2.3.19-rc  
 Keywords:  MikePerry201208  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------

Comment(by nickm):

 circuit_finish_handshake() is called on every EXTENDED cell, and every
 CREATED cell we get from a first hop.  That's it.  ("git grep
 circuit_finish_handshake".)

 The thing to look for instead would be calls to
 circuit_send_next_onion_skin, which is the function that actually
 increments the value in question.  It is unfortunately called from ALL
 OVER the codebase.

 The network scanner is the thing I'm interested in, not the hidden
 services.  Check out handle_control_extendcircuit -- it calls
 circuit_send_next_onion_skin.  Could controller-driven circuit creation be
 at issue here?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6475#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online