[tor-bugs] #6475 [Tor Client]: circuit_send_next_onion_skin(): Bug: Unexpectedly high circuit_successes

[Tor Bug Tracker & Wiki]

#6475: circuit_send_next_onion_skin(): Bug: Unexpectedly high circuit_successes
-----------------------------+----------------------------------------------
 Reporter:  grarpamp         |          Owner:  mikeperry         
     Type:  defect           |         Status:  assigned          
 Priority:  major            |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client       |        Version:  Tor: 0.2.3.19-rc  
 Keywords:  MikePerry201208  |         Parent:                    
   Points:                   |   Actualpoints:                    
-----------------------------+----------------------------------------------
Changes (by mikeperry):

 * cc: armadev, karsten, ioerror (added)


Comment:

 nickm/arma/karsten: Are either of you guys aware of ways
 circuit_finish_handshake() might not get called in the hidden service code
 upon circuit completion? That sounds like what this but is, but I'm not
 really clear on how hidden service circuit construction differs from
 normal circuit construction. I assumed the codepaths were the same.

 It's either that, or we missed a case where circuits can be counted for
 success twice in circuit_send_next_onion_skin().

 If we can't find codepaths for either of these, I guess the next question
 is: Can we repro without hidden service use involved?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/6475#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online