[tor-bugs] #1035 [Tor Relay]: Relay on dynamic IP marked as stable and guard

[Tor Bug Tracker & Wiki]

#1035: Relay on dynamic IP marked as stable and guard
--------------------------+-------------------------------------------------
    Reporter:  rudis      |       Owner:  Sebastian         
        Type:  defect     |      Status:  needs_review      
    Priority:  minor      |   Milestone:  Tor: 0.2.2.x-final
   Component:  Tor Relay  |     Version:  0.2.0.35          
  Resolution:  None       |    Keywords:                    
      Parent:             |      Points:                    
Actualpoints:             |  
--------------------------+-------------------------------------------------

Comment(by Sebastian):

 Staring at this more, I'm convinced that all the ways how we could
 possibly end up calling this with an orport and not an address is a
 serious bug, even with nickm's safety check before calling
 rep_hist_note_router_reachable() from dirserv_orconn_tls_done(). I think
 asserting that either both are set or unset is the right thing to do here.

 Updated my branch with a commit to change that, also taking out the
 conditional logging. Please review again?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1035#comment:32>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online