[tbb-bugs] #30239 [Applications/Tor Browser]: TBA: Gracefully handle auto-restart after crash

[Tor Bug Tracker & Wiki]

#30239: TBA: Gracefully handle auto-restart after crash
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile tbb-8.5-must              |  Actual Points:
  TorBrowserTeam201904                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by sysrqb):

 * cc: sisbell (added)


Comment:

 Shane, I'll create a patch for the tor-android-service project in tor-
 browser-build for this, but do you think this is reasonable? I haven't
 tested it yet (so this is a little bit of a guess). Essentially, I'm
 thinking about this:

 {{{
 diff --git
 a/service/src/main/java/org/torproject/android/service/TorService.java
 b/service/src/main/java/org/torproject/android/service/TorService.java
 index a748241..80c1dfa 100644
 --- a/service/src/main/java/org/torproject/android/service/TorService.java
 +++ b/service/src/main/java/org/torproject/android/service/TorService.java
 @@ -270,7 +270,7 @@ public final class TorService extends Service
 implements TorServiceConstants, Or
              mExecutor.execute(new IncomingIntentRouter(intent));
          else
              Log.d(OrbotConstants.TAG, "Got null onStartCommand()
 intent");
 -        return Service.START_STICKY;
 +        return Service.START_NOT_STICKY;
      }

      @Override
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30239#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online