[tbb-bugs] #30239 [Applications/Tor Browser]: TBA: Gracefully handle auto-restart after crash

[Tor Bug Tracker & Wiki]

#30239: TBA: Gracefully handle auto-restart after crash
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile tbb-8.5-must              |  Actual Points:
  TorBrowserTeam201904                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 The correct solution involves handling the Fragment lifecycle correctly.

 The simple explanation for why this is happening is Fennec starts its
 services (like MediaControlService) with the `START_NOT_STICKY` value
 which means the service is not automatically restarted when the system
 kills the app. On the other hand. Orbot's TorService is started with
 `START_STICKY`, so the system restarts it automatically. This results in
 part of the previous state being restored when it is restarted, but not
 the entire state. In this case, the Fragment instances are recreated, but
 they aren't correctly initialized. We can (and should) change how we
 implement `TorBootstrapPager` in the future, but the easy solution is
 tweaking `TorService` so it doesn't automatically restart after being
 killed. Automatically restarting the service doesn't provide any
 noticeable performance improvements and it is only causing problems right
 now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/30239#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online