[tbb-bugs] #26409 [Applications/Tor Browser]: Language prompt is shown twice at first start in Tor Browser based on ESR60

[Tor Bug Tracker & Wiki]

#26409: Language prompt is shown twice at first start in Tor Browser based on ESR60
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  ff60-esr, tbb-torbutton,             |  Actual Points:
  AffectsTails, TorBrowserTeam201808R            |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Thanks for the review (and it counts as one :) ). We don't use
 `merge_ready`, thus just leaving state is fine.

 Regarding your two points:

 1) The design doc currently specifies the state of Tor Browser 7.0. Once
 we update it to 8.0 mentioning the pref will be removed.

 2) Yes, once we fetch the updated localized files they won't have the
 string in it anymore after it's gone in the `en` version. Thus, we are
 good here.

 The torbutton commit got applied to `master`
 (e950aeac23670983bedd84c6526bb9a865450a25) and the tor-browser one to
 `tor-browser-60.1.0esr-8.0-1` (49b80d55c275d4a59484b8e955d9d4eeac2d8d44),
 thanks!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26409#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online