[tbb-bugs] #26409 [Applications/Tor Browser]: Language prompt is shown twice at first start in Tor Browser based on ESR60

[Tor Bug Tracker & Wiki]

#26409: Language prompt is shown twice at first start in Tor Browser based on ESR60
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff60-esr, tbb-torbutton,             |  Actual Points:
  AffectsTails, TorBrowserTeam201808R            |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by intrigeri):

 I've tested this in a running Tails system with 8.0a9 (by applying your
 patches inside omni.ja and the torbutton xpi) and it worked just fine.
 Thanks!

 Code review passes modulo a couple nitpicks:

 * `website/design/design.xml` and `website/design/index.html.en` still
 refer to the obsolete `extensions.torbutton.spoof_english`; this probably
 does not block merging these branches though since even without this fix,
 the corresponding sections were obsolete already (they don't mention the
 new Firefox locale spoofing feature that we now rely upon)
 * the localized `torbutton.properties` files still have
 `torbutton.popup.prompted_language`; maybe they're updated automatically
 later during the build or release process?

 I'm not a Torbutton developer so even though I'm quite at ease with this
 part of the code, I'm leaving this is ''needs_review''. Let me know if I
 should have been bold enough to make this ''merge_ready''.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26409#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online