[tbb-bugs] #13443 [Tor Browser]: TB v4.0 (xul.dll) crashes on Windows

[Tor Bug Tracker & Wiki]

#13443: TB v4.0 (xul.dll) crashes on Windows
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  cypherpunks            |     Status:  new
         Type:  defect   |  Milestone:
     Priority:           |    Version:
  critical               |   Keywords:  tbb-crash, tbb-helpdesk-frequent,
    Component:  Tor      |  TorBrowserTeam201410
  Browser                |  Parent ID:
   Resolution:           |
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by cypherpunks):

 Patch for BaseFilter:
 {{{
      return E_POINTER;
    }

 -  if (riid == IID_IBaseFilter || riid == IID_IUnknown) {
 +  if (riid == IID_IBaseFilter || riid == IID_IUnknown ||
 +      riid == __uuidof(BaseFilter)) {
      *aInterface = static_cast<IBaseFilter*>(this);
    } else if (riid == IID_IMediaFilter) {
      *aInterface = static_cast<IMediaFilter*>(this);
 }}}
 and for BasePin:
 {{{
      return E_POINTER;
    }

 -  if (aIID == IID_IPin || aIID == IID_IUnknown) {
 +  if (aIID == IID_IPin || aIID == IID_IUnknown ||
 +      aIID == __uuidof(BasePin)) {
      *aInterface = static_cast<IPin*>(this);
    } else if (aIID == IID_IQualityControl) {
      *aInterface = static_cast<IQualityControl*>(this);
 }}}
 Probably non working/wrong, and for sure incomplete. Yet another
 QueryInterfaces waiting for some patching too.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13443#comment:46>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online