[tbb-bugs] #13443 [Tor Browser]: TB v4.0 (xul.dll) crashes on Windows

[Tor Bug Tracker & Wiki]

#13443: TB v4.0 (xul.dll) crashes on Windows
-------------------------+-------------------------------------------------
     Reporter:           |      Owner:  tbb-team
  cypherpunks            |     Status:  new
         Type:  defect   |  Milestone:
     Priority:           |    Version:
  critical               |   Keywords:  tbb-crash, tbb-helpdesk-frequent,
    Component:  Tor      |  TorBrowserTeam201410
  Browser                |  Parent ID:
   Resolution:           |
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------

Comment (by cypherpunks):

 If to change uuids for [https://mxr.mozilla.org/mozilla-
 esr31/source/media/webrtc/trunk/webrtc/modules/video_capture/windows/BaseFilter.h#158
 BaseFilter] and for [https://mxr.mozilla.org/mozilla-
 esr31/source/media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.h#205
 BasePin] to IID_IUnknown, like tested with binary patching:
 {{{
 Comparing files xul.dll and xul_patch.dll
 01EC9880: 54 00
 01EC9881: D3 00
 01EC9882: EB 00
 01EC9883: 4D 00
 01EC9884: C6 00
 01EC9885: B0 00
 01EC9886: AB 00
 01EC9887: 44 00
 01EC9888: 93 C0
 01EC9889: CF 00
 01EC988A: 49 00
 01EC988B: F6 00
 01EC988C: 4E 00
 01EC988D: D3 00
 01EC988E: 6A 00
 01EC988F: B8 46
 01EC9890: C6 00
 01EC9891: 69 00
 01EC9892: 96 00
 01EC9893: 19 00
 01EC9894: 2A 00
 01EC9895: 67 00
 01EC9896: 30 00
 01EC9897: 41 00
 01EC9898: B1 C0
 01EC9899: 3E 00
 01EC989A: 57 00
 01EC989B: AA 00
 01EC989C: 83 00
 01EC989D: 0E 00
 01EC989E: AE 00
 01EC989F: 55 46
 }}}
 Then QueryInterface for [https://mxr.mozilla.org/mozilla-
 esr31/source/media/webrtc/trunk/webrtc/modules/video_capture/windows/BaseFilter.cpp#186
 BaseFilter] [https://mxr.mozilla.org/mozilla-
 esr31/source/media/webrtc/trunk/webrtc/modules/video_capture/windows/BasePin.cpp#181
 BasePin] returns proper interface instead of E_NOINTERFACE and no crash
 happens.

 MSVC generated code never calls QueryInterface for mentioned uuids.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13443#comment:45>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online