[metrics-bugs] #22754 [Metrics/CollecTor]: Reference checker should only read relay descriptors

[Tor Bug Tracker & Wiki]

#22754: Reference checker should only read relay descriptors
-----------------------------------+--------------------------
     Reporter:  karsten            |      Owner:  metrics-team
         Type:  defect             |     Status:  new
     Priority:  Medium             |  Milestone:
    Component:  Metrics/CollecTor  |    Version:
     Severity:  Normal             |   Keywords:
Actual Points:                     |  Parent ID:
       Points:                     |   Reviewer:
      Sponsor:                     |
-----------------------------------+--------------------------
 I just noticed that `ReferenceChecker` reads bridge descriptors in my
 local test instance. Looks like we changed paths in
 [https://gitweb.torproject.org/collector.git/commit/?id=8767c73d0826dfa9aa21e70a2d857c8a2d77e524
 this commit] to include all recent descriptors, not just recent relay
 descriptors:

 {{{
 -    new ReferenceChecker(new File("recent/relay-descriptors"),
 -        new File("stats/references"),
 -        new File("stats/references-history")).check();
 +    new ReferenceChecker(
 +        recentPath.toFile(),
 +        new File(config.getPath(Key.StatsPath).toFile(), "references"),
 +        new File(config.getPath(Key.StatsPath).toFile(), "references-
 history")).check();
 }}}

 We should probably change that back to avoid reading descriptors we don't
 care about anyway.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22754>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online