[tor-talk] torsocks logic

[grarpamp]

On Sun, Oct 30, 2016 at 8:22 AM, Isidor Zeuner <onions at quidecco.de> wrote:
> there seems to be some discrepancy in torsocks' logic, at least
> since August 2016.

Current release was October 18...
https://gitweb.torproject.org/torsocks.git/

Update and verify against that and file bug in trac
as needed under torsocks.
https://trac.torproject.org/


> In "src/common/utils.c", check_addr returns -1 for non-AF addresses.
>
> So does utils_is_address_ipv4 as it just passes check_addr's
> return value.
>
> However, in "src/lib/gethostbyname.c", tsocks_gethostbyname expects
> the return value to be a C boolean, so the -1 value from above is
> treated as a positive result.
>
> I guess one of the three functions may better be adjusted in order to
> ensure more effective operation.