[tor-relays] Can't compile 0.4.6.5 on Ubuntu 18.04

[William Denton]

I went to upgrade a relay running on Ubuntu 18.04 to the new release (0.4.6.5) 
and to my surprise it didn't compile.  Every other version has built without any 
trouble.  Wading into the Gitlab site was rather confusing, so I thought I'd 
send this here, in the hopes it reaches the right people and someone else might 
be interested.

I ran ./configure, then make, and pretty soon this happened:

   CC       src/feature/dirclient/dirclient.o
In file included from ./src/core/or/or.h:50:0,
                  from src/feature/dirclient/dirclient.c:13:
src/feature/dirclient/dirclient.c: In function ‘dir_client_decompress_response_body’:
./src/lib/log/ratelim.h:55:27: error: initializer element is not constant
  #define RATELIM_INIT(r) { (r), 0, 0, 0 }
                            ^
src/feature/dirclient/dirclient.c:1877:38: note: in expansion of macro ‘RATELIM_INIT’
      static ratelim_t warning_limit = RATELIM_INIT(LOG_INTERVAL);
                                       ^~~~~~~~~~~~
./src/lib/log/ratelim.h:55:27: note: (near initialization for ‘warning_limit.rate’)
  #define RATELIM_INIT(r) { (r), 0, 0, 0 }
                            ^
src/feature/dirclient/dirclient.c:1877:38: note: in expansion of macro ‘RATELIM_INIT’
      static ratelim_t warning_limit = RATELIM_INIT(LOG_INTERVAL);
                                       ^~~~~~~~~~~~
Makefile:12141: recipe for target 'src/feature/dirclient/dirclient.o' failed
make[1]: *** [src/feature/dirclient/dirclient.o] Error 1
make[1]: Leaving directory '/usr/local/src/tor/tor-0.4.6.5'


Thanks,

Bill

--
William Denton
https://www.miskatonic.org/
Librarian, artist and licensed private investigator.