[tor-qa] fix for some tbb test suite issues ?

Nicolas Vigier boklm at mars-attacks.org
Wed Aug 20 10:08:25 UTC 2014


On Tue, 19 Aug 2014, Gunes Acar wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi Nicolas,
> 
> Here's the patch:
> https://github.com/gunesacar/tbb-fp-tests/blob/master/always.patch
> 
> It removes the check for the "always" option and prevents
> printing of the test names that are not enabled.
> 
> A new corner case was: when you run some tests without running
> the tor_bootstrap, stop_tor (TorBootstrap.pm) gets called before
> running start_tor in the first place.
> 
> Then it (stop_tor) tries to kill a non-existing Tor process and gives
> the following error: "Can't kill a non-numeric process ID..."
> 
> So I added a check for the tor pid to fix this.
> 
> Hope that's all fine, please check the patch since I don't know Perl
> at all.

Thanks. This looks good.

Can you make this in git patches (with git format-patch) ?

Nicolas



More information about the tor-qa mailing list