[tor-dev] 3.2.10 compiler warnings

[teor]

Thanks for the bug report.

> On 10 Mar 2018, at 04:54, grarpamp <grarpamp at gmail.com> wrote:
> 
> Test from an older system before it was updated,

Can you tell us what compiler and version, and what system?
Any arguments to configure?
And how did you get the Tor source code?

> unlikely to be prevalent, so don't bother fixing unless obvious.

I don't know why we didn't catch these warnings earlier.

> src/common/confline.c:135: warning: 'include_list' may be used
> uninitialized in this function
> src/common/confline.c:135: warning: 'include_list' may be used
> uninitialized in this function

This is spurious, but I'm not surprised the compiler can't tell.
We should fix it.

> src/or/connection.c:1883: warning: passing argument 1 of 'TO_OR_CONN'
> discards qualifiers from pointer target type
> src/or/conscache.c:426: warning: passing argument 2 of
> 'consensus_cache_entry_map' discards qualifiers from pointer target
> type
> src/or/control.c:6815: warning: passing argument 1 of 'TO_OR_CONN'
> discards qualifiers from pointer target type

These are annoying, and can sometimes be bugs.

> src/or/scheduler.c:577: warning: format '%ld' expects type 'long int',
> but argument 5 has type 'time_t'

Please tell us about your system, we thought we had caught most of
these warnings.

> src/or/connection.c:1883: warning: passing argument 1 of 'TO_OR_CONN'
> discards qualifiers from pointer target type
> src/or/conscache.c:426: warning: passing argument 2 of
> 'consensus_cache_entry_map' discards qualifiers from pointer target
> type
> src/or/control.c:6815: warning: passing argument 1 of 'TO_OR_CONN'
> discards qualifiers from pointer target type
> src/or/scheduler.c:577: warning: format '%ld' expects type 'long int',
> but argument 5 has type 'time_t'

As above.

> src/test/vote_descriptors.inc:93: warning: string length '4135' is
> greater than the length '4095' ISO C99 compilers are required to
> support
> src/test/test_hs_descriptor.inc:224: warning: string length '14104' is
> greater than the length '4095' ISO C99 compilers are required to
> support
> src/test/test_microdesc.c:648: warning: string length '5844' is
> greater than the length '4095' ISO C99 compilers are required to
> support
> src/test/test_descriptors.inc:305: warning: string length '10571' is
> greater than the length '4095' ISO C99 compilers are required to
> support

We turn off this warning, why does your compiler report it?

T