[tor-dev] Reviewing prop224 fixes

[George Kadianakis]

David Goulet <dgoulet at ev0ke.net> writes:

> [ text/plain ]
> On 04 Apr (13:07:29), George Kadianakis wrote:
>> John Brooks <john.brooks at dereferenced.net> writes:
>> 
>> > [ text/plain ]
>> > (Thread forked from [tor-dev] Notes from the prop224 proposal reading group)
>> >
>> <snip> 
>>
>> OK I addressed the comments above in my branch `prop224-fixes`.
>> I also ripped out the MAINT_INTRO command as was discussed. 
>> 
>> Please see: https://gitweb.torproject.org/user/asn/torspec.git/log/?h=prop224-fixes
>> 
>> (I didn't change the key type thing you pointed out. Not sure if changing it to
>> the old type / len / key architecture would make things better. Please let me
>> know if you decide it will.)
>> 
>> > 442f0b3791797ebbac3feb2bffb87318fe8d84 "Clarify prop224 use of shared random”
>> >
>> > Seems like we will need a lot more detail on how the shared random values are used
>> > for the hash ring, the process for switching to the new SRV, and so on. Is somebody
>> > planning to write that up? Has it all been decided yet?
>> >
>> 
>> Agreed. Looking at the time period logic is next on my stack, and my plan is to
>> make another thread similar to this one.
>> 
>> >> 
>> >> Stuff I need to look into next:
>> >> - Can we simplify the backwards compat logic?
>> >> - Should we add extensions to the rendezvous cells (at the cost of failing backwards compat)?
>> >> - Address more TODOs (there are a bunch of hard ones in there).
>> >> - Clean up some messy sections.
>> >> - Figure out the fate of UPDATE-KEYS-SUBCMD (see my previous mail).
>> >
>> > Happy to discuss any of these any time. My list right now is:
>> >
>> > - Look at onion hostnames, figure out the extra 4 bits and potentially a checksum
>> > - Fix client authentication
>> > - Thinking more about denial of service, especially on hsdirs
>> >
>> 
>> Sounds good. Let me know when you have thoughts or patches.
>
> I'm happy with the current changes! I say you can merge them upstream in
> torspec or wait for a nickm/roger ack :)
>

OK, I merged the spec changes from this thread upstream.

They should be on the HEAD of https://gitweb.torproject.org/torspec.git .

Thanks for the feedback!