[tor-dev] Code review request for bug #9701

[michael at schloh.com]

Hello Ken,

On Thurs., May 15, 2014, Ken Keys wrote:
>On 5/15/2014 9:38 AM, michael at schloh.com wrote:
>> If anybody's feeling particularly friendly, then it would be nice of
>> you to do the favour of reviewing the proposed solution to bug #9701:
>>
>> https://trac.torproject.org/projects/tor/ticket/9701
>>
>> It relates to clipboard turds of the Tor Browser in violation of
>> the premise of disk avoidance by design. The code in question is
>> attached to the bug report.
>>
>1. Some versions of the SunOS--maybe Solaris too, I'm not sure--had
>a provision where you could copy text without any explicit clip board
>action. You could just select the text and middle click in the
>destination. Will this change break that behavior or are these
>systems still supported?
>
I couldn't find any official requirements doc stating that all POSIX
or certain versions of certain POSIX/LINUX distros are supported.

Regardless of this, I think the highlight and middle click thing
is a X11 feature. Good idea to bring this up, but since my Linux
tests included mouse as well as middle click action this probably
extends to SunOS and other POSIX OSs using X11. Is that your gut
feeling too? You think we need more testing using real (VM) SunOS
and other platforms?

>2. My second concern is a style issue. If I read msvb-9701.diff
>correctly, you propose to just comment out the offending code with a
>preprocessor directive. I, along with others who are more knowledgeable,
>think that this process is bad form. It tends to leave the source code
>cluttered with a great deal of non-functioning code. While it is
>worthwhile to preserve the history, that is what source code control
>systems are for.
>
This is a good idea, and I'll use your good advice.

Thanks a lot.

Regards,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3379 bytes
Desc: not available
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20140515/530b7762/attachment.bin>