[tor-dev] test_memcpy() on Windows

Gisle Vanem gvanem at yahoo.no
Fri Mar 14 21:23:15 UTC 2014


"Nick Mathewson" <nickm at alum.mit.edu> wrote:

>> I assume this test works on Linux where AFAICS malloc() returns a buffer
>> with zeros. If so, shouldn't calloc() be used in 'setup_data_buffer()'
>> instead?
> 
> The test is broken: it doesn't work on any platform.  Look how buffer2
> was copied directly from buffer1: they can't be unequal, on any
> platform, no matter what malloc does.

Ok. I had some trouble expanding that macro in my head.

> Fixed in tinytest; copied into Tor.

Fine.

--gv


More information about the tor-dev mailing list