[tor-dev] Call for testing/review: obfsclient

[Yawning Angel]

On Thu, 13 Feb 2014 14:06:39 +0100
Fabian Keil <freebsd-listen at fabiankeil.de> wrote:
> Trying to build it on FreeBSD 11.0-CURRENT I get (after a couple
> of other issues):

FreeBSD has Clang as the default compiler right?  I've been using GCC
for development, sorry, I should have tested both.

> fk at r500 ~/git/obfsclient $make obfsclient
> [ 91%] Built target obfsclient_lib
> [100%] Building CXX object src/CMakeFiles/obfsclient.dir/main.cc.o
> In file included from /home/fk/git/obfsclient/src/main.cc:49:
> /home/fk/git/obfsclient/src/schwanenlied/pt/scramblesuit/client.h:145:60:
> error: implicit instantiation of undefined template
> 'std::__1::array<unsigned char, 1448>' ::std::array<uint8_t,
> kHeaderLength + kMaxPayloadLength> decode_buf_;
> ^ /usr/include/c++/v1/__tuple:69:60: note: template is declared here
> template <class _Tp, size_t _Size> struct _LIBCPP_TYPE_VIS array; ^
> In file included from /home/fk/git/obfsclient/src/main.cc:49:
> /home/fk/git/obfsclient/src/schwanenlied/pt/scramblesuit/client.h:64:14:
> error: cannot initialize return object of type 'Socks5Server::Session
> *' with an rvalue of type 'schwanenlied::pt::scramblesuit::Client *'
> return new Client(base, sock, addr, addr_len);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 errors generated.

I've installed Clang, so I locally fixed all the other minor issues[0]
you probably encountered but I didn't encounter the last error, I think
I know why it's unhappy and believe it's fixed.

commit 581bb2ac42be529b7bb5f8617a3c362ac38e47f9
commit 218c86b501f897a6c6b6e0bd14bde9ada5488b5d
commit 594caa7f36ae9f5a465324eda983b70c6289fcfb <- master

Please let me know if it's still broken/if I've missed anything.

-- 
Yawning Angel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20140213/f69caa79/attachment-0001.sig>