[tor-dev] jtorctl

[Michael Rogers]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 04/04/14 15:44, Nathan Freitas wrote:
> *ahem* Orbot represents 2 million users of jtorctl, and it works
> just fine for us (in our limited use of it).
> 
> https://gitweb.torproject.org/orbot.git/tree/HEAD:/external

Hehe, I was just this second cloning the Orbot repo to see if you were
still using jtorctl. :-) Briar also uses it, as does Ploggy.

On 04/04/14 07:54, Karsten Loesing wrote:
> Michael, are you working on JTorCtl because you want to help out
> with writing some Java code?  If so, I might have some other fine
> Java code for you to hack on that is in active use:

I'd love to help, but right now I've got too much on my plate to take
on any new projects. Sorry!

> Or are you using JTorCtl for some project of yours?  In that case
> it might be easier to keep your own JTorCtl branch for now and ask
> for your changes to be merged when you publish your application.
> Of course, you could also open a Trac ticket and ask for review,
> but that might take between a while and forever.

I'm happy to maintain a fork - that's what I've been doing until now,
but I thought it might be useful to push my changes upstream. Here's a
summary of the changes:

1. Make TorControlConnection thread-safe
2. Convert TorControlError and TorControlSyntaxError into checked
exceptions
3. Reduce the visibility of classes and methods
4. Use the Java 1.5 foreach operator for readability
5. Fix formatting of javadoc comments

Points 2 and 3 might affect existing users of the library. I'm happy
to post five small patches or one big patch for eventual review if you
think Trac's the way to go.

Cheers,
Michael

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEcBAEBCAAGBQJTPtFHAAoJEBEET9GfxSfMMjAIAK9ajy2Efe1m+hYp6sw9EuJV
+KhoUD3UMCq9GWsq93hATZVhrRbV5bpOJvEjaikd9/Ux6TA6888Ngi23LWh7D/Er
aaVjm87AoAhMOeaOEXXsmlIqAi8+DRA7jZbE2zHB3TYAjVEU7/KKWY+1J57+j3nu
n01Yfr2bp0XeEFJ1a9Q6RPZdhYGo6u0OMsjh9etQoEoDdE+0NR2PYRpUz1sigi/q
DYEdxeX66ZTVaEOm4KndSEjmacxt86xQrbsaCGovLb97iUxXa1gv4W66ATTC5aIi
A+9Y9v2RmfxynyhQh8QGCd8edxGJ5vQ8M+ISinDIBeq4UiY225r2MWt5GWUQrHc=
=4UPM
-----END PGP SIGNATURE-----