[tor-dev] Design for an exit relay scanner: feedback appreciated

Philipp Winter identity.function at gmail.com
Tue Dec 3 11:38:43 UTC 2013


On Sun, Dec 01, 2013 at 05:09:55PM -0800, Damian Johnson wrote:
> You might want to look into PEP8 [1], Python's de-facto style guide.
> It's certainly up to you which bits you do/don't like, but coming
> close will make your code more uniform with the rest of the Python
> world. PyPI has a slick pep8 script you can run over your codebase
> [2]. Personally I run this as part of the tests for Stem.

Thanks for all your remarks.  That's very helpful feedback!

> Would you be amenable to changes in that regard from me? This looks
> like a fun project, so I'm a bit tempted to sink a weekend or two into
> into seeing if I can simplify the codebase.

Sure, absolutely.  You should wait a couple of days before doing
that, though.  After Lunar's suggestions, I'm significantly
restructuring the code.

Cheers,
Philipp


More information about the tor-dev mailing list