[tor-dev] stem test output
Karsten Loesing
karsten at torproject.org
Wed Jun 27 08:42:19 UTC 2012
On 6/25/12 3:45 AM, Damian Johnson wrote:
> Karsten, should the 'dirreq-v3-share' percentage values be able to go
> above 100%? The extra-info descriptors that I just fetched has one
> such entry, which makes stem's descriptor parser complain...
>
> extra-info siltornado 995D0FE5A89563D79A383CCC2444D0E26C6BE625
> published 2012-06-24 19:30:31
> ...
> dirreq-v2-share 159.81%
> dirreq-v3-share 159.81%
Nice catch. That's a bug. Good thing we don't use self-reported
directory request shares anymore. I commented on #5823 which is about
removing these lines from little-t-tor. For stem, I'd say, let's accept
shares above 100%, because dir-spec.txt doesn't explicitly limit the
range to 0--100%.
Best,
Karsten
More information about the tor-dev
mailing list