[tor-dev] Unused -v and -F options in torperf/trivsocks-client?

David Fifield david at bamsoftware.com
Fri Jul 29 20:34:23 UTC 2011


On Fri, Jul 29, 2011 at 08:39:15PM +0100, Steven Murdoch wrote:
> Hi Karsten, David,
> 
> On 29 Jul 2011, at 05:00, Karsten Loesing wrote:
> > Hmm, for some reason I don't get those errors (or warnings) about unused
> > variables.  But I think you're right in that these variables can go away.
> > 
> > This is Steven's code, so I'd like to hear his opinion before applying
> > the patch.  Steven?
> 
> That patch looks fine to me. I didn't get the warnings either, so perhaps you're using a newer GCC.

I've only started seeing those warnings since GCC 4.6. I noticed some
tor commits to fix similar things, for example
https://gitweb.torproject.org/tor.git/commit/a5232e0c4c572cdff85701f698b8b90c9443d7e4.

David Fifield


More information about the tor-dev mailing list