Rejecting risky extend cells?

Roger Dingledine arma at mit.edu
Wed Aug 20 06:00:29 UTC 2008


On Tue, Aug 19, 2008 at 11:53:19AM -0400, Nick Mathewson wrote:
> On Mon, Aug 18, 2008 at 11:54:45PM -0400, Roger Dingledine wrote:
> > Hi Nick, others,
> > 
> > Does this need a proposal, or is it a clearly good patch? Ideas
> > suggested by rovv.
> 
> Looks good to me.  I'd say check it in,

r16605

> and mark as backportable for 0.2.0.x.

r16606

> In addition to checking for 2-hop loops, though, we should also check
> for 1-hop loops (i.e., extending to yourself).  Do we?

We do. connection_or_connect() checks if (server_mode(options) &&
router_digest_is_me(id_digest)), and returns null if so.

--Roger



More information about the tor-dev mailing list