TODO: Add a way to request DNS resolves from the controller

[Robert Hogan]

On Thursday 05 July 2007 18:38:13 Nick Mathewson wrote:
>   - As written, if there's more than one controller that uses the
>     RESOLVE command, all of them are informed whenever _any_ of them
>     gets a "650 RESOLVE".  (This is the big one, the rest are cosmetic
>     and easy to fix.)

I could only think of one way to fix this and it wasn't very pretty. Included 
it anyway. It also removes the ability to have concurrent resolve requests on 
the same controller, e.g. 'resolve hotmail.com google.com' will only do 
hotmail.com.

>
>   - Using a new socks command isn't right here: this isn't new
>     functionality.  Instead, it would probably be best to add a bit to
>     the edge_connection_t struct.
>

Fixed.

>   - evdns_server_control() is almost entirely cut-and-pated code.
>     That's bad.  Common code should be in a function.
>

Didn't do anything here. It's copy and pasted from all over the place, so 
couldn't see a way of saving anything more than a few lines. Will be 
interested to see how it should be done.

>   - The evdns_* prefix is reserved for functions in evdns.c.
>
>   - The handle_control_* prefix is for handling control commands from
>     a controller.
>
Fixed.

Thanks,
Rob

-- 

Browse Anonymously Anywhere	- http://anonymityanywhere.com
TorK	- KDE Anonymity Manager	- http://tork.sf.net
KlamAV	- KDE Anti-Virus 	- http://www.klamav.net

-------------- next part --------------
A non-text attachment was scrubbed...
Name: controllerresolve2.diff
Type: text/x-diff
Size: 10432 bytes
Desc: not available
URL: <http://lists.torproject.org/pipermail/tor-dev/attachments/20070710/9c02613e/attachment.diff>